Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device updates for TPU Pod #7243

Merged
merged 5 commits into from
Apr 30, 2021
Merged

Device updates for TPU Pod #7243

merged 5 commits into from
Apr 30, 2021

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Apr 27, 2021 •
edited
Loading

What does this PR do?

Fixes #7197

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Apr 27, 2021 •
edited
Loading

Codecov Report

Merging #7243 (94b2a24) into master (338f5a3) will decrease coverage by 4%.
The diff coverage is 17%.

@@           Coverage Diff           @@
##           master   #7243    +/-   ##
=======================================
- Coverage      91%     87%    -4%     
=======================================
  Files         199     199            
  Lines       12797   12800     +3     
=======================================
- Hits        11678   11145   -533     
- Misses       1119    1655   +536

@kaushikb11 kaushikb11 marked this pull request as ready for review April 29, 2021 17:00
@kaushikb11 kaushikb11 self-assigned this Apr 29, 2021
@kaushikb11 kaushikb11 added bug Something isn't working priority: 0 High priority task accelerator: tpu Tensor Processing Unit labels Apr 29, 2021
awaelchli
awaelchli approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice <3

any significant changelog necessary?

pytorch_lightning/core/step_result.py Show resolved Hide resolved
tests/models/test_tpu.py Show resolved Hide resolved
@awaelchli awaelchli added this to the v1.3 milestone Apr 29, 2021
@mergify mergify bot removed the has conflicts label Apr 30, 2021
@kaushikb11 kaushikb11 enabled auto-merge (squash) April 30, 2021 10:41
tchaton
tchaton approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@carmocca
Copy link
Contributor

@kaushikb11 TPU tests failing

@kaushikb11 kaushikb11 disabled auto-merge April 30, 2021 14:44
@kaushikb11 kaushikb11 enabled auto-merge (squash) April 30, 2021 14:45
@kaushikb11 kaushikb11 disabled auto-merge April 30, 2021 16:42
@kaushikb11 kaushikb11 merged commit 490cc57 into Lightning-AI:master Apr 30, 2021
@kaushikb11 kaushikb11 deleted the tpu/pod branch April 30, 2021 17:44
@kaushikb11 kaushikb11 mentioned this pull request May 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@ananthsub ananthsub ananthsub left review comments

@tchaton tchaton tchaton approved these changes

@carmocca carmocca carmocca approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@kaushikb11 kaushikb11

Labels
accelerator: tpu Tensor Processing Unit bug Something isn't working priority: 0 High priority task
Projects
None yet
Milestone
pl:1.3
Development

Successfully merging this pull request may close these issues.

No TPU Devices found for TPU Pod Training, even after recognizing it
5 participants
@kaushikb11 @carmocca @ananthsub @awaelchli @tchaton